Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks image/binary files #187

Open
mix3d opened this issue Mar 3, 2016 · 1 comment
Open

Breaks image/binary files #187

mix3d opened this issue Mar 3, 2016 · 1 comment

Comments

@mix3d
Copy link

mix3d commented Mar 3, 2016

I'm not sure if this is bug-worthy or not, but it took me forever to find out why all my image files were getting borked; it turns out it was useref.

Because I am also using gulp-rev-all to version files after useref generates them, I needed all the files for the entire web-app in the same filestream. Following the examples, I blindly piped everything through useref.

At a minumum the docs could be updated to mention this, and maybe add an example of lots of files and using gulp-if or gulp-filter to get just the html files for the useref pipe?

Regardless, useref shouldn't be editing a file if it doesn't find the correct keys, right? Is there a way to discern that it is a binary, not a text file, and ignore it? (Still new to node.js and gulp)

@mix3d mix3d changed the title Breaks image files Breaks image/binary files Mar 3, 2016
@jonkemp
Copy link
Owner

jonkemp commented Apr 13, 2016

I don't see this as a huge problem that needs solving. This is the first time I've ever had this complaint. I do think additional docs could help though, like a recipe section or an examples section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants