Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiving this Repo and Moving to gulp-html-minifier-terser #107

Open
MaheshCasiraghi opened this issue Apr 3, 2020 · 3 comments
Open

Comments

@MaheshCasiraghi
Copy link

MaheshCasiraghi commented Apr 3, 2020

Dependency on: html-minifier version 3.x makes it impossible to fix some bugs, such as minifyJS not working.

I suggest archiving this seemingly dead repository and moving to a minify-terser based fork, such as: gulp-html-minifier-terser.

@MaheshCasiraghi MaheshCasiraghi changed the title Archiving this Repo and Moving to gulp-html-minifier-terser Archiving this Repo and Moving to gulp-html-minifier-terser Apr 3, 2020
@gmfmi
Copy link

gmfmi commented Jun 4, 2020

@MaheshCasiraghi, thank you so much for this issue, you made my day!

I was digging into the project source code to understand why the JS compression wasn't working as expected but it is now a lot more clearer.

I just switched to gulp-html-minifier-terser and now everything works.

@paulshryock
Copy link

So glad I'm not crazy re: minifyJs not working. Thanks for this issue.

@nCubed
Copy link

nCubed commented Sep 24, 2021

1.5 years or so after @MaheshCasiraghi comment and still no updates. Assuming the gulp-htmlmin package has been abandoned. Moving on to gulp-html-minifier-terser; bonus as they both use nearly identical settings syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants