Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement type predicate #27

Open
PumpedSardines opened this issue Oct 15, 2021 · 0 comments
Open

Implement type predicate #27

PumpedSardines opened this issue Oct 15, 2021 · 0 comments

Comments

@PumpedSardines
Copy link

Summary

Currently isObject returns the type boolean, but i think it would improve the package if it returned val is { [key: string]: unknown }.

Current behaviour

const test: { example: "hello" } | string[] = ...;

if(isObject(test)) {
  test.example = "world" // Error since test could be a string array
}

Improved behaviour

const test: { example: "hello" } | string[] = ...;

if(isObject(test)) {
  test.example = "world" // No error 
}
@PumpedSardines PumpedSardines changed the title Implement type predicates Implement type predicate Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant