Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling error with 3.1.1 #25

Closed
KittyGiraudel opened this issue May 15, 2018 · 5 comments
Closed

Bundling error with 3.1.1 #25

KittyGiraudel opened this issue May 15, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@KittyGiraudel
Copy link

KittyGiraudel commented May 15, 2018

Good morning! 馃憢

As per 3.1.1 (which changed bundling system to iife), Webpack bundling of classcat causes the following error:

TypeError: classcat__WEBPACK_IMPORTED_MODULE_1___default(...) is not a function

With all due respect, I suggest not changing what your library exports in a patch. 馃槃

You probably should roll back to 3.1.0 or publish 3.1.2 with amd bundling and offer iife in 4.0.0 or optionally in a minor along side with the existing export interface.

Hope it helps!

@jorgebucaran
Copy link
Owner

jorgebucaran commented May 15, 2018

@hugogiraudel I don't understand. Why doesn't webpack pick up the module field from pkg.json pointing to the ES6 source?

"module": "src/index.js",

So, what should we do / export then? Go back to UMD or is there a way to make it work like this by exporting an IIFE? 馃

With all due respect, I suggest not changing what your library exports in a patch.

Thanks, makes sense.

@jorgebucaran jorgebucaran added the bug Something isn't working label May 15, 2018
@KittyGiraudel
Copy link
Author

As of right now, version 3.1.1 is breaking a lot of builds because of the change of export. Since it is not possible to unpublish a version, I suggest you either:

  • publish 3.1.0 as 3.1.2,
  • or change the type of bundling back to umd in 3.1.2.

Maybe we ask someone from Webpack to shed some light on that issue once the fix has been published. :)

@jorgebucaran
Copy link
Owner

I am looking at this webpack/webpack#1979, maybe it is related.

@jorgebucaran
Copy link
Owner

@hugogiraudel Could you share the part of your webpack config where you specify the target? I suppose it is node?

@jorgebucaran
Copy link
Owner

jorgebucaran commented May 15, 2018

Anyway, here is 3.1.2 unbreaking the issue.

3.1.1 will be remembered as the rogue one.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants