Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently broken for Windows with MSYS2 #136

Open
tasop-rsconnect opened this issue Jan 27, 2021 · 3 comments
Open

Currently broken for Windows with MSYS2 #136

tasop-rsconnect opened this issue Jan 27, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@tasop-rsconnect
Copy link

Installing a version of node (specifically 10.23.2) has the following problems:

  • OS detection doesn't work.
    This is because nvm.fish line 42 uses string lower, but line 52 compares to uppercase strings.
  • Solving the above, curl (line 81) fails with curl: (23) Failure writing output to destination
    I worked around that by having curl save to a temp file, and then tar read from that file.
  • Working around the above, the tar part of installing (line 82) fails for some reason I couldn't determine.
    It works if I separate it into two commands instead of using && or ; and in lines 81-82.
  • Working around the above, _nvm_node_info fails because apparently npm is directly inside version/bin instead of node_modules/npm, so package.json isn't in the same directory.

Using it on Windows 10 with MSYS2.
curl version: 7.74.0 (x86_64-pc-msys)
tar version: bsdtar 3.3.2 - libarchive 3.3.2 zlib/1.2.5.f-ipp

I decided against making a pull request since I only have workarounds for the above and I can't be sure it would work in general, but I can hope this information helps you figure out the problems.

@jorgebucaran jorgebucaran added the bug Something isn't working label Jan 27, 2021
@M4RC3L05
Copy link

@tasop-rsconnect I had the same issues you describe, so i made a fork with patches for msys2/mingw here, maybe this can help.

@jorgebucaran If this is a good solution i'm happy to make a PR.

@jorgebucaran
Copy link
Owner

I'd love a PR! @M4RC3L05

@matteopt
Copy link

matteopt commented Jul 28, 2022

@jorgebucaran
I've created a new pull request to fix this, it uses either unzip or bsdtar (included in MSYS2).
#192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants