Skip to content

Commit e2c419a

Browse files
committedMar 8, 2024·
fix: context menu not closing when clicking a button in a dropdown menu
1 parent c66ee09 commit e2c419a

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed
 

‎src/lib/components/controls/contextmenu/ContextMenuDropDownButton.svelte

+9-1
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,17 @@
77
export let item: MenuDropDownButton
88
export let className: string | undefined = undefined
99
export let onCloseContextMenu: () => void
10+
11+
$: items = item.items.map(item => ({
12+
...item,
13+
onClick: (event: MouseEvent) => {
14+
onCloseContextMenu()
15+
item.onClick(event)
16+
}
17+
}))
1018
</script>
1119

12-
<DropdownButton width={item.width} items={item.items}>
20+
<DropdownButton width={item.width} items={items}>
1321
<button
1422
class={classnames('jse-context-menu-button', className, item.main.className)}
1523
type="button"

‎src/routes/development/+page.svelte

+1-1
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@
381381
382382
function onRenderContextMenu(items: ContextMenuItem[], context: RenderMenuContext) {
383383
console.log('onRenderContextMenu', items, context)
384-
return items // This return is equivalent to onRenderContextMenu is undefined
384+
return items
385385
}
386386
387387
function openInWindow() {

0 commit comments

Comments
 (0)
Please sign in to comment.