Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant ["set"] metadata from diff #26

Open
josephburnett opened this issue Dec 14, 2020 · 1 comment
Open

Remove redundant ["set"] metadata from diff #26

josephburnett opened this issue Dec 14, 2020 · 1 comment

Comments

@josephburnett
Copy link
Owner

The ["set"] metadata emitted by the diff operations is not strictly necessary. The use of an object implies set semantics and it works fine without it.

jd should stop emitting that metadata (but should continue supporting its explicit use). Makes the simple use cases easier to read.

@josephburnett
Copy link
Owner Author

Instead of

@ ["foo",["set"],{}]
- "bar"
+ "baz"

we should emit

@ ["foo",{}]
- "bar"
+ "baz"

because it’s visually cleaner and they do the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant