-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated to gatsby v4 and now mdx image variables renders as text instead of a path #114
Comments
Hey @AlexanderThiele! By the time you opened the issue, the theme didn't support Gatsby 4, but today I released a new version that supports v4. Let me know if the problem persists after updating it. I recommend creating a fresh install of the theme, using the starter https://github.com/jpedroschmitz/gatsby-starter-rocketdocs. |
Awesome! Many thanks! I will test and let you know asap! |
Hey @jpedroschmitz, i still have the same issue. i found a workaround. I created a new react component: import React from "react";
export default function DocImg(props) {
var {img, title, className, width } = props
return <>
<a href={img} target="_blank" title="open image in a new tab"><img src={img} alt={title} title={title} className={className} width={width} /></a>
</>
} and used it in the docs <DocImg img={apikeyImg} title="LinkFive.io - How to create a new Api Key" /> I have implemented your docs a little bit different. it's part of a bigger gatsby project where /docs are rendered with your lib and everything else is custom gatsby. the the issue could also appear because of some other dependencies I use. |
Just wanted to see if there is a resolution for this too, I plan to have a lot of images in my docs and as a complete newbie I'm looking for an easy way to manage a bunch of images in my project and then referencing them throughout different documents. |
Summary
Hello!
thanks for this lib! I recently updated gatsby to the latest version
"gatsby": "^4.2.0"
and also your lib to the latest version.I'm currently testing and my images don't really seem to work anymore. Here is what i do:
inside the MDX file i import the image and use it as the src of an img.
When i check the console, the html is rendered like this:
<img src="{abc}" />
The strange part is that if i change the src tag to anything else, it works. For example like this:
Then the rendered HTML looks like this:
which is the correct png path.
i actually don't know that to do anymore. do you have any ideas?
Relevant information
Another thing i found during develop launch
i checked the yarn.lock file and your lib is the only dependency of gatsby-plugin-mdx
The text was updated successfully, but these errors were encountered: