fix(job): make ctx and env binding to Job instances to use in handle() #57

mileszim · 2023-10-01T21:51:41Z

This makes the env and ctx params available to Job instances. Resolves #56

jplhomer · 2023-11-17T12:48:02Z

packages/superflare/src/queue.ts

  );
 }

-async function handleQueueMessage(message: Message, ctx: ExecutionContext) {
+async function handleQueueMessage<Env>(message: Message, ctx: ExecutionContext, env: Env) {
  const instance = await hydrateInstanceFromQueuePayload(
    message.body as MessagePayload


I think it would make more sense to pass ctx and env here as second or third args, since that function is responsible for hydrating an instance. (even if we only end up assigning it for Job instances). Thoughts?

fix(job): make ctx and env binding to Job instances to use in handle()

653956e

jplhomer reviewed Nov 17, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(job): make ctx and env binding to Job instances to use in handle() #57

fix(job): make ctx and env binding to Job instances to use in handle() #57

mileszim commented Oct 1, 2023

jplhomer Nov 17, 2023

fix(job): make ctx and env binding to Job instances to use in handle() #57

Are you sure you want to change the base?

fix(job): make ctx and env binding to Job instances to use in handle() #57

Conversation

mileszim commented Oct 1, 2023

jplhomer Nov 17, 2023

Choose a reason for hiding this comment