Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fs.spaces #401

Closed
RyanZim opened this issue Apr 8, 2017 · 4 comments
Closed

Remove fs.spaces #401

RyanZim opened this issue Apr 8, 2017 · 4 comments
Assignees
@RyanZim

Comments

@RyanZim
Copy link
Collaborator

RyanZim commented Apr 8, 2017

Perhaps I'm doing something wrong, but I can't get fs.spaces working.

Test case: https://runkit.com/57ebc041d4a27f140028fd78/58e92c306fa07e0013ccb3e6

@jprichardson ?
@jprichardson
Copy link
Owner

Maybe we should remove fs.spaces?

@RyanZim
Copy link
Collaborator Author

RyanZim commented Apr 8, 2017

Suits me; it isn't documented anyhow; users who need it can use jsonfile. If people really complain, we can add it back.

@RyanZim RyanZim self-assigned this Apr 8, 2017
@RyanZim RyanZim changed the title fs.spaces doesn't seem to work Remove fs.spaces Apr 8, 2017
@RyanZim RyanZim mentioned this issue Apr 8, 2017
Merged
@RyanZim
Copy link
Collaborator Author

RyanZim commented Apr 8, 2017

PR done: #402

@RyanZim
Copy link
Collaborator Author

RyanZim commented Apr 10, 2017 •
edited

Fixed in #402; should be released in v3.0.0.

@RyanZim RyanZim closed this as completed Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanZim RyanZim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jprichardson @RyanZim