copy/copySync meta issue

[RyanZim]

@manidlou I think you mentioned copySync still needs updated to match the changes you made to copy in develop. Is that correct? What else needs done before releasing the work done on develop?

Just FYI, I'm planning on releasing a major version with just the changes in copy/copySync; that way if there's regressions, we can simply tell people not to upgrade until we get things fixed.

---

Edit: Tasklist:

• copySync needs updated to match copy
  • Remove recursive option
  • Fix Prevent copying a directory into itself #83
  • Fix handle copying between identical files #198
  • Fix copySync empty folder into an existing file #464
• Port fs.copy, handle e.g. EBUSY #511 to develop

[RyanZim]

Posting here, just a reminder to myself that I want to add async filter function support sometime, not sure if I'll get it done in this release.

[manidlou]

That's correct @RyanZim. In terms of changes for copySync, these are the things that I think need to be changed or fixed:

• There is a recursive option that was never been documented, which I think needs to be removed as it directly affects the copySync behavior for symlinks (src). Related issue: copySync('my_symlink') always dereferences the symlink  #447.
• copySync currently fails for the old and infamous issues of Prevent copying a directory into itself #83 and handle copying between identical files #198 as well as copySync empty folder into an existing file #464.
• I also like to test if we get a better perf by using recursive pattern instead of Array.forEach when copying directories.

I do my best to complete them as fast as possible!

I'm planning on releasing a major version with just the changes in copy/copySync; that way if there's regressions, we can simply tell people not to upgrade until we get things fixed.

Sounds good! 👍

[RyanZim]

Also noting #511 needs ported.

I'm starting a tasklist in the OP; @manidlou please check off items that are merged to develop.

[RyanZim]

Anything else that needs done here @manidlou?

[manidlou]

Anything else that needs done here @manidlou?

I think we are done here!