Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why no promisified lchmod? #595

Closed
ramhejazi opened this issue Jun 20, 2018 · 7 comments
Closed

Why no promisified lchmod? #595

ramhejazi opened this issue Jun 20, 2018 · 7 comments
Labels
bug promises
Milestone
7.0.0

Comments

@ramhejazi
Copy link
Contributor

Why the module does not promisify the fs.lchmod function? The api array in lib/fs/index.js doesn't have an element for lchmod function.
@RyanZim
Copy link
Collaborator

RyanZim commented Jun 20, 2018

That's a mistake on our part, and a bug. PR welcome.

@RyanZim
Copy link
Collaborator

RyanZim commented Jun 20, 2018

I should also file an issue with normalize/fs

@ramhejazi
Copy link
Contributor Author

Thanks for the fast reply. I submitted a PR.

@ramhejazi ramhejazi mentioned this issue Jun 20, 2018
Merged
@ramhejazi
Copy link
Contributor Author

ramhejazi commented Jul 16, 2018 •
edited

What a long week Ryan! I have temporarily added the function to fs-extra in a package that I was developing: https://github.com/ramhejazi/draxt/blob/master/src/interfaces/Node.js#L18

@RyanZim
Copy link
Collaborator

RyanZim commented Jul 16, 2018

So sorry, this slipped through the cracks on me, I will try to patch as soon as I can.

@ramhejazi
Copy link
Contributor Author

No worries and no need to say sorry man. It just needed one line for temporarily fixing it.

@RyanZim RyanZim added this to the 7.0.0 milestone Jul 17, 2018
RyanZim pushed a commit that referenced this issue Jul 17, 2018
@ramhejazi @RyanZim
Add missing element for fs.lchmod promisification (#595) (#596)
1a4e885
@RyanZim
Copy link
Collaborator

RyanZim commented Jul 17, 2018

Fixed in #596; will be released in v7

@RyanZim RyanZim closed this as completed Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug promises
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@RyanZim @ramhejazi