Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should have fs.realpath*.native() function #650

Closed
wants to merge 1 commit into from

Conversation

gucong3000
Copy link

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 85.714% when pulling 347b87d on gucong3000:realpath_native into a32c852 on jprichardson:master.

@manidlou
Copy link
Collaborator

manidlou commented May 13, 2019

That's right we have to add that! But wondering if we explicitly have to add that to the api!

Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should support fs.realpath*.native() but this isn't the way to do it. We've got to support both promises and callbacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants