Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fs.copyFile fallback #754

Closed
RyanZim opened this issue Feb 4, 2020 · 2 comments · Fixed by #755
Closed

Remove fs.copyFile fallback #754

RyanZim opened this issue Feb 4, 2020 · 2 comments · Fixed by #755
Assignees
@manidlou
Labels
feature-copy
Milestone
9.0.0

Comments

@RyanZim
Copy link
Collaborator

RyanZim commented Feb 4, 2020

Now that #751 is merged, there's no reason to have a fallback for fs.copyFile/fs.copyFileSync. We should remove them from the copy implementation.
@RyanZim RyanZim added this to the 9.0.0 milestone Feb 4, 2020
@RyanZim
Copy link
Collaborator Author

RyanZim commented Feb 4, 2020

@manidlou are you up to this, or shall I do it?

@manidlou
Copy link
Collaborator

manidlou commented Feb 4, 2020

@RyanZim I will take care of it. I really appreciate all your work!

@manidlou manidlou self-assigned this Feb 4, 2020
@manidlou manidlou mentioned this issue Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manidlou manidlou

Labels
feature-copy
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

copy*(): remove copyFileFallback jprichardson/node-fs-extra
2 participants
@manidlou @RyanZim