Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promisify fs.rm #841

Closed
RyanZim opened this issue Oct 19, 2020 · 0 comments · Fixed by #860
Closed

Promisify fs.rm #841

RyanZim opened this issue Oct 19, 2020 · 0 comments · Fixed by #860
Labels
promises

Comments

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 19, 2020

Related to #806, but making it a separate issue to be explicit.

We need to add fs.rm to our list of fs methods to add promise support to.
@RyanZim RyanZim added this to the 10.0.0 milestone Oct 19, 2020
@RyanZim RyanZim removed this from the 10.0.0 milestone Jan 18, 2021
RyanZim added a commit that referenced this issue Jan 18, 2021
@RyanZim
Add promise support for fs.rm()
af30e1f 
Fixes #841
@RyanZim RyanZim mentioned this issue Jan 18, 2021
Merged
RyanZim added a commit that referenced this issue Jan 19, 2021
@RyanZim
Add promise support for fs.rm() (#860)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d409cf8 
Fixes #841
This was referenced Mar 12, 2021
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
promises
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add promise support for fs.rm() jprichardson/node-fs-extra
1 participant
@RyanZim