Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Buffer.allocUnsafe() in enviroments that support it #394

Merged
merged 1 commit into from Mar 17, 2017
Merged

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Mar 16, 2017

Resolves #391

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 86.277% when pulling a86d8b4 on buffer into 84717b8 on master.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Mar 16, 2017

Should I add a small instanceof test case for the buffer util?

@jprichardson
Copy link
Owner

Should I add a small instanceof test case for the buffer util?

What do you mean?

@jprichardson
Copy link
Owner

Oh like instanceof Buffer inside of the Buffer util function? Use Buffer.isBuffer()

@manidlou
Copy link
Collaborator

Should I add a small instanceof test case for the buffer util?

I am still not sure what you mean. You mean test if the returning result of the buffer util is an instanceof Buffer?

@RyanZim
Copy link
Collaborator Author

RyanZim commented Mar 16, 2017

I was wondering if I should add a testcase to lib/util/__test__ that tests the buffer util and ensures that it returns a buffer.

@manidlou
Copy link
Collaborator

I was wondering if I should add a testcase to lib/util/test that tests the buffer util and ensures that it returns a buffer.

Oh alright. Basically it is a good idea to have test for each feature that we add or change. However, I am not sure if this one is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants