Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix function isSrcSubdir in the copy-sync.js and copy.js #541

Merged
merged 1 commit into from Feb 21, 2018

Conversation

kolgotko
Copy link
Contributor

The problem occurs when:
src = /tmp/path/src
dest = /prefix/tmp/path/src

Repository owner deleted a comment from coveralls Jan 16, 2018
Repository owner deleted a comment from coveralls Jan 16, 2018
@RyanZim RyanZim requested a review from manidlou January 16, 2018 13:15
@RyanZim
Copy link
Collaborator

RyanZim commented Jan 16, 2018

I'm not sure I fully understand this change; why is the behavior different on Windows?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.498% when pulling 801bd12 on kolgotko:master into fab376e on jprichardson:master.

@kolgotko
Copy link
Contributor Author

Now behavior is tested for Windows too.

Repository owner deleted a comment from coveralls Jan 16, 2018
@manidlou
Copy link
Collaborator

Thanks @kolgotko! Will you squash this please?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.498% when pulling 067c1cd on kolgotko:master into fab376e on jprichardson:master.

@kolgotko
Copy link
Contributor Author

That is how it should be?

@manidlou manidlou requested a review from RyanZim January 19, 2018 23:09
@RyanZim RyanZim merged commit a0d44c1 into jprichardson:master Feb 21, 2018
facebook-github-bot pushed a commit to facebook/flipper that referenced this pull request Nov 14, 2018
Summary:
Changes are mostly bug fixes, that shouldn't affect us. From the change log:

7.0.1 / 2018-11-07
------------------

- Fix `removeSync()` on Windows, in some cases, it would error out with `ENOTEMPTY` ([#646](jprichardson/node-fs-extra#646))
- Document `mode` option for `ensureDir*()` ([#587](jprichardson/node-fs-extra#587))
- Don't include documentation files in npm package tarball ([#642](jprichardson/node-fs-extra#642), [#643](jprichardson/node-fs-extra#643))

7.0.0 / 2018-07-16
------------------

- **BREAKING:** Refine `copy*()` handling of symlinks to properly detect symlinks that point to the same file. ([#582](jprichardson/node-fs-extra#582))
- Fix bug with copying write-protected directories ([#600](jprichardson/node-fs-extra#600))
- Universalify `fs.lchmod()` ([#596](jprichardson/node-fs-extra#596))
- Add `engines` field to `package.json` ([#580](jprichardson/node-fs-extra#580))

6.0.1 / 2018-05-09
------------------

- Fix `fs.promises` `ExperimentalWarning` on Node v10.1.0 ([#578](jprichardson/node-fs-extra#578))

6.0.0 / 2018-05-01
------------------

- Drop support for Node.js versions 4, 5, & 7 ([#564](jprichardson/node-fs-extra#564))
- Rewrite `move` to use `fs.rename` where possible ([#549](jprichardson/node-fs-extra#549))
- Don't convert relative paths to absolute paths for `filter` ([#554](jprichardson/node-fs-extra#554))
- `copy*`'s behavior when `preserveTimestamps` is `false` has been OS-dependent since 5.0.0, but that's now explicitly noted in the docs ([#563](jprichardson/node-fs-extra#563))
- Fix subdirectory detection for `copy*` & `move*` ([#541](jprichardson/node-fs-extra#541))
- Handle case-insensitive paths correctly in `copy*` ([#568](jprichardson/node-fs-extra#568))

Reviewed By: jknoxville

Differential Revision: D13023753

fbshipit-source-id: 1ecc6f40be4c8146f92dd29ede846b5ab56765ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants