Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callbacks.remove(callbacks) argument can be comma separated list not array #1181

Open
70ray opened this issue Jan 29, 2021 · 3 comments
Open

Comments

@70ray
Copy link

70ray commented Jan 29, 2021

The documentation for the argument suggests it can be an array like: callbacks.remove([func1, func2]). This does not work. But callbacks.remove(func1, func2) does. The documentation should clarify this.

@70ray 70ray changed the title callbacks.remove(callbacks) argument can be comma sparated list not array callbacks.remove(callbacks) argument can be comma separated list not array Jan 29, 2021
@mgol
Copy link
Member

mgol commented Feb 19, 2021

Would you like to submit a PR? That page is defined here: https://github.com/jquery/api.jquery.com/blob/main/entries/callbacks.remove.xml

@70ray
Copy link
Author

70ray commented Mar 11, 2021

Thanks,
In my test it seemed the documentation did not agree with what the code actually did but I am not certain which should be changed and haven't looked into other similar cases to see if there is any consistent pattern.

@mgol
Copy link
Member

mgol commented Mar 11, 2021

The current behavior has been in the code forever so it's a de-facto standard, no one could have realistically depended on the documented version. The fix needs to land in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants