Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packagers] Support additional file extensions in brew #1594

Open
aalmiray opened this issue Feb 9, 2024 · 1 comment
Open

[packagers] Support additional file extensions in brew #1594

aalmiray opened this issue Feb 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@aalmiray
Copy link
Member

aalmiray commented Feb 9, 2024

As of 1.10.0 the brew package only supports .zip extensions for a handful of distributions

static {
Set<String> extensions = setOf(ZIP.extension());
SUPPORTED.put(NATIVE_IMAGE, extensions);
SUPPORTED.put(BINARY, extensions);
SUPPORTED.put(JAVA_BINARY, extensions);
SUPPORTED.put(JLINK, extensions);
SUPPORTED.put(NATIVE_PACKAGE, setOf(ZIP.extension(), DMG.extension(), PKG.extension()));
SUPPORTED.put(SINGLE_JAR, setOf(JAR.extension()));
SUPPORTED.put(FLAT_BINARY, emptySet());
}

Linux artifacts usually prefer .tar.gz or .tgz as archive formats.

Discussed at #1593

@aalmiray aalmiray added the enhancement New feature or request label Feb 9, 2024
@aalmiray
Copy link
Member Author

aalmiray commented Feb 9, 2024

Adding this behavior as is would break builds as there may be more than one matching artifact for a brew packager. Thus this behavior must be guarded with a configuration flag and be disabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant