Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packagers] Should the homebrew tap formula file name have a different casing than the cask name? #1652

Closed
crschnick opened this issue May 3, 2024 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@crschnick
Copy link

I'm currently creating another homebrew cask with a hyphen in its name. I'm not a homebrew expert, but I was under the impression that the formula file name should be equal to the formula/cask name in the file. But it seems like jreleaser modifies the .rb file name to remove hyphens and capitalize parts.

When creating a cask with a hyphen in jreleaser, the homebrew client will complain about the mismatch in file names and cask names and refuse to install the cask.

@crschnick crschnick added the bug Something isn't working label May 3, 2024
@aalmiray
Copy link
Member

aalmiray commented May 3, 2024

From the docs at https://docs.brew.sh/Cask-Cookbook

The Cask name (<cask-token>) on the header line cask <cask-token> do should match the cask filename, without the .rb extension, enclosed in double quotes.

@crschnick
Copy link
Author

Alright then this is probably jreleaser bug. The file name is then not correct for casks, haven't tested with formulas yet.

@aalmiray aalmiray changed the title Should the homebrew tap formula file name have a different casing than the cask name? [packagers] Should the homebrew tap formula file name have a different casing than the cask name? May 3, 2024
@aalmiray aalmiray added the good first issue Good for newcomers label May 3, 2024
@aalmiray aalmiray added this to the v1.13.0 milestone May 3, 2024
@aalmiray
Copy link
Member

aalmiray commented May 3, 2024

Additional info regarding formula naming conventions https://docs.brew.sh/Formula-Cookbook#a-quick-word-on-naming

@aalmiray aalmiray self-assigned this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants