Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Possibility to use SolidJS? #8

Open
2 tasks done
FlurryNight opened this issue Dec 24, 2022 · 10 comments
Open
2 tasks done

enhancement: Possibility to use SolidJS? #8

FlurryNight opened this issue Dec 24, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@FlurryNight
Copy link

Description

Just found about this solution and first of all, Thank you for doing it. Projects like this matter.

I was wondering if we could use SolidJS as the view library since u mentioned agnostic, I don't know if it's doable with Remix internals but SolidJS in Remix would be the cherry on top of the cake, at least until Solid Start reaches stable and gets mature.

Thank you everyone involved in this project and Happy Holidays🎅

Suggested solution

Provide a @remix-kit/solidjs package

Alternative

No response

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@cliffordfajardo
Copy link
Collaborator

That would be nice ; I think one of the first things that might need to happen is getting an implementation of react-router-dom done in SolidJS

The remix core team posted this repo of work some people in the community are doing to create react-router-dom (i think eventually remix team will cause this remix-router in other frameworks

One thing that's highlighted in the remix-routers repo above that SSR support in these implementations is work in progress. I think in a few months when remix team finishes integrating remix-router into remix core that might make the work simpler, lots of moving parts in the core remix repo happening right now

@FlurryNight
Copy link
Author

That would be nice ; I think one of the first things that might need to happen is getting an implementation of react-router-dom done in SolidJS

The remix core team posted this repo of work some people in the community are doing to create react-router-dom (i think eventually remix team will cause this remix-router in other frameworks

One thing that's highlighted in the remix-routers repo above that SSR support in these implementations is work in progress. I think in a few months when remix team finishes integrating remix-router into remix core that might make the work simpler, lots of moving parts in the core remix repo happening right now

Oh that's awesome, ty for the info, didn't know about that repo. Lets hope for that

@jrestall
Copy link
Owner

Hi @FlurryNight, appreciate the input and suggestion!

As @cliffordfajardo mentioned it will depend on remix-routers support. We would then look to combine that with an existing Vite plugin to provide SSR support. Similar to how the @remix-kit/vue library is being setup (https://github.com/jrestall/remix-kit/blob/main/packages/remix-vue/src/setup.ts).

remix-routers is only focussed on CSR though, so there is also a dependent piece of work to create a headless version of a lot of the @remix-run/react components like Links and RemixBrowser so that any view library (vue, preact, svelte, solid etc) could easily build their own components. Hopefully this would be done and maintained by Remix but if Vue or some other library is important to someone then they could make a start and potentially contribute it back to Remix.

It's mentioned that remix-kit is view agnostic since none of the main libraries like cli, kit, vite care what view library you use and support can be added with a separate package e.g. @remix-kit/react.

@jrestall jrestall added the enhancement New feature or request label Dec 25, 2022
@FlurryNight
Copy link
Author

Hi @FlurryNight, appreciate the input and suggestion!

As @cliffordfajardo mentioned it will depend on remix-routers support. We would then look to combine that with an existing Vite plugin to provide SSR support. Similar to how the @remix-kit/vue library is being setup (https://github.com/jrestall/remix-kit/blob/main/packages/remix-vue/src/setup.ts).

remix-routers is only focussed on CSR though, so there is also a dependent piece of work to create a headless version of a lot of the @remix-run/react components like Links and RemixBrowser so that any view library (vue, preact, svelte, solid etc) could easily build their own components. Hopefully this would be done and maintained by Remix but if Vue or some other library is important to someone then they could make a start and potentially contribute it back to Remix.

It's mentioned that remix-kit is view agnostic since none of the main libraries like cli, kit, vite care what view library you use and support can be added with a separate package e.g. @remix-kit/react.

Hey, Okay.

Exact, the ideal would be it to be maintained by Remix

That's amazing that you can change the view library like if u were using Astro. Lets hope for that to be possible with Remix and remix-kit in a few months , sure would add even more value to the Remix framework as folks could use their favorite library, and they don't have to stick to the one the framework works.

Thank you again, Have a nice day!

@jrestall
Copy link
Owner

Progress is being made on a solid js router for Remix https://twitter.com/nivekithanS/status/1607019446308335616 👀

@FlurryNight
Copy link
Author

Progress is being made on a solid js router for Remix https://twitter.com/nivekithanS/status/1607019446308335616 👀

Big WoW 🎉 , ty for keeping me posted

@cliffordfajardo
Copy link
Collaborator

@FlurryNight - looks like @nivekithan is working on a solidjs port of react router 👀

@nivekithan
Copy link

Yeah I am working on solid js integration. Right now it's just integration with remix_run/router and that too only for client side.

I have also fallen little behind on my pr (got an laptop issue) hopefully I will make an pr in next two days.

@FlurryNight
Copy link
Author

Yeah I am working on solid js integration. Right now it's just integration with remix_run/router and that too only for client side.

I have also fallen little behind on my pr (got an laptop issue) hopefully I will make an pr in next two days.

Thank you @nivekithan , hope u sort it out, do u have plans to make it SSR after successfully porting ?

@nivekithan
Copy link

If the pr is accepted and the remix team is also interested in adding support for ssr, then yeah I am planning to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants