Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off warnings as well as errors? #25

Open
Heydon opened this issue Oct 14, 2016 · 4 comments
Open

Turn off warnings as well as errors? #25

Heydon opened this issue Oct 14, 2016 · 4 comments

Comments

@Heydon
Copy link

Heydon commented Oct 14, 2016

The warnings for missing assets are quite verbose. Can I have a way to turn them off? Or is there a way already?

@jrit
Copy link
Owner

jrit commented Oct 14, 2016

Not really at the moment. If you set strict to true then an exception gets thrown instead, but I'm quite sure that isn't what you want here :) I'd accept a PR to set a logLevel, but it likely isn't something I'll work on myself.

@Heydon
Copy link
Author

Heydon commented Oct 14, 2016

@jrit Thank you for the reply. In my case, the warnings involve using SVG xlink. I tried getting these to be ignored using data-inline as an exception for images.

<a href="#{{slug}}" aria-label="link">
  <svg><use data-inline xlink:href="#icon-link"></use></svg>
</a>

But this didn't work. Any ideas? (I tried data-inline on the <svg> element too...)

@tommedema
Copy link
Contributor

tommedema commented Sep 24, 2017

@jrit I'm considering to write a PR for this. Any suggestion on the approach, i.e. the different log levels (or simply a boolean whether to log or not?), and which lines of code are relevant?

@jrit
Copy link
Owner

jrit commented Oct 2, 2017

@tommedema that strict option should probably be removed and replaced with a strictness option that takes one of error, warning, silent, or something like that. The current default would be equivalent to warning which I think should be kept. The relevant lines should be easy to find by searching for occurrences of the strict option. Let me know if you have other thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants