Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deal with svg fill urls? #38

Open
tommedema opened this issue Dec 23, 2017 · 1 comment
Open

How to deal with svg fill urls? #38

tommedema opened this issue Dec 23, 2017 · 1 comment

Comments

@tommedema
Copy link
Contributor

tommedema commented Dec 23, 2017

I'm not an expert on svgs, but apparently the fill attribute can have anchors that are referencing to svg definitions like so:

screen shot 2017-12-23 at 16 28 24

In this case the given url should not be embedded, since it is a reference rather than something you can base64 encode. Right? What's your take on this?

@jrit
Copy link
Owner

jrit commented Dec 25, 2017

I think you might be a level deeper on SVGs than I had considered. The docs around SVG are focused on inlining SVG files into HTML content, rather than inlining the content within SVGs. In any case, my understanding (which could be wrong) is that if one wanted to inline that reference, they could and the datatype would be data:image/svg+xml but nobody has ever actually requested this as a feature so my inclination is that it would be more practical if this is causing you a problem to open a PR to exclude hashes from url inlining rather than add support for inlining SVG within SVG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants