Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NUMBER() function #3

Merged
merged 61 commits into from
Nov 7, 2021
Merged

Implement NUMBER() function #3

merged 61 commits into from
Nov 7, 2021

Conversation

jrmajor
Copy link
Owner

@jrmajor jrmajor commented Nov 5, 2021

Partially resolves #2.

@jrmajor
create locale data compilers for number formatter
89913ac
@jrmajor
cu
b7fc51c
@jrmajor
commit compiled locale data
a5d4a3b
@jrmajor
skip invalid minorUnits in currencies compiler
86db491
@jrmajor
rename FluentNumber::setFluentLocale()
d445287 
rename FluentNumber::setFluentLocale() to setLocale()
@jrmajor
mark FluentNumber as final
7406a71
@jrmajor
add @return $this annotations
abbb5c0
@jrmajor
remove plusSign from locale data
84d9006
@jrmajor
formatting
98bc2c9
@jrmajor
refactor test case
09223ab
@jrmajor
create equalsNodeOutput assertion
4abb57c
@jrmajor
add basic number formatter
0b01d7f 
supports decimal and percent formatting, no currency formatting yet
@jrmajor
change symbols order in compiled locales
c2425d7
@jrmajor
count unique locale values popularity
8015b28
@jrmajor
optimize locale data
a71eaaa
@jrmajor
optimize currencies data
afd3291
@jrmajor
fix escaping in currency data
4f9350f
@jrmajor
enable phpstan analysis for locales data
f3ddd42
@jrmajor
replace make-numbers with symfony console app
0d5839b
@jrmajor
fix escaping in locale data
26e7f5d
@jrmajor
formatting
76bb3ca
@jrmajor
refactor FluentNumber to use NumberFormatter
0fc155a 
use setOptions instead of minimumFractionDigits argument
@jrmajor
implement NUMBER function
9136583
@jrmajor
catch runtime function exceptions
75f3b96
@jrmajor
make NUMBER function retain trailing zeroes
ee2ae75
@jrmajor
formatting
5814b85
@jrmajor
make exception constructors internal
efdaa70
@jrmajor
improve assertTranslation assertion
c998a8e
@jrmajor
fix phpstan error
6313297
@jrmajor
formatting
7157c46
@jrmajor
refactor locale compiler helpers
5251847
@jrmajor
formatting
af4277b
@jrmajor
add thecodingmachine/phpstan-safe-rule
c5488db
@jrmajor
add gen application name
b618259
@jrmajor
mark FluentNumber methods as internal
844eb46
@jrmajor
throw InvalidArgument instead of custom exception
8c48995
@jrmajor
fix exception message
7043b98
@jrmajor
NumberFormatter cleanup
f90b8bf
@jrmajor
throw error for currency numer formatting style
cd99257
@jrmajor
extract locale data loader from numberformatter
cdd6aaa
@jrmajor
fix typo
db88c25
@jrmajor
optimize currencies data
371b960
@jrmajor
commit compiled locale data
70c4069
@jrmajor
optimize currencies data
af4038c 
371b960
@jrmajor
commit compiled locale data
4e11dec
@jrmajor
optimize currencies data
e2aa435
@jrmajor
commit compiled locale data
8054937
@jrmajor
optimize currencies data
8d2e6b4
@jrmajor
commit compiled locale data
a28d591
@jrmajor
small refactors
159a2c0
@jrmajor
add locale data required for currency formatting
ff350b0
@jrmajor
include narrowSymbol in currencies data
ed250f8
@jrmajor
commit compiled locale data
965bdd5
@jrmajor
fix assertNumberFormat assertion
596a32c
@jrmajor
add currency formatting support
3603fa2
@jrmajor
fix assertion
486c160
@jrmajor jrmajor marked this pull request as ready for review November 7, 2021 16:33
@jrmajor jrmajor merged commit e1eddce into master Nov 7, 2021
@jrmajor jrmajor deleted the number-formatter branch November 7, 2021 16:37
jrmajor added a commit that referenced this pull request Nov 8, 2021
@jrmajor
merge #3: replace a few deps with azjezz/psl
b96d3dd 
replace a few external dev dependencies with azjezz/psl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATETIME and NUMBER functions
1 participant
@jrmajor