Cookies.get(undefined) returns all cookies

[sammok]

Dear developer,

When I use Cookies.get() method, I passing a undefined variable as a parameter into get method,

bug returns all cookies,

I think, Cookie.get() method should checking the arguments length, if arguments.length > 0, this method shouldn't returns all the cookies, returns undefined would be better.

Test Case:

console.log(Cookies.get(), Cookies.get(undefined), Cookies.get(null))
output: {}, {}, {}

expect

console.log(Cookies.get(), Cookies.get(undefined), Cookies.get(null))
output: {}, undefined, undefined

[FagnerMartinsBrack]

Cookies.get(undefined) is not documented - e.g there's no such API. Why are you using the API like that? Can you share some examples?

[FagnerMartinsBrack]

Closing due to the lack of feedback from the OP. If you want to continue the discussion, please comment here mentioning one of the project members.

[jackocnr]

Hi there, I've recently hit a related issue - if I have the cookie name in a variable, and in some situations I need to be able to handle where that variable is not set, or it has a default value like null or empty string, in those cases it makes more sense to me for get to return null instead of all of the cookies. As the op says, if I pass in a value, then I think it shows an intent to fetch a particular cookie, and certainly not all of the cookies.

Honestly it just feels dangerous to use the same get method for two completely different use cases, to retrieve two different data types. I would favour get always being to get a particular cookie, and having some new method e.g. getAll if you want to get all cookies, to make it explicit. What do you think?

[FagnerMartinsBrack]

Opening due to @jackocnr feedback. In this case, we should be doing if arguments.length > 0. Similar problem as of carhartl/jquery-cookie#308

@jackocnr do you want to create a test and PR for this?

[jackocnr]

Thanks for your response. I'm very busy at the mo, but I might be able to take a look one weekend if I find the time.

[FagnerMartinsBrack]

Sure @jackocnr feel free to take the time it takes :)

[FagnerMartinsBrack]

@jackocnr any news on this?

[jackocnr]

Nope. It's still on my list, but I haven't found the time yet.

[carhartl]

I believe we can change

return key ? jar[key] : jar

to

return arguments.length >= 1 ? jar[key] : jar

Will tackle this later..

[carhartl]

Ha, that would have worked if it was not for getJSON()...

[FagnerMartinsBrack]

@carhartl Is it time to dump getJSON either in favor of people doing JSON.stringify(Cookies.get('name')), Cookies.get('name', JSON.parse(value))? I don't see a valid point in encouraging things like Cookies.getJSON().a.foo.bar -> If one level of JSON is removed from the store, the code crashes.

[carhartl]

Is it time to dump getJSON

I didn't even think of that.. open a ticket and try to gather some thoughts?

[FagnerMartinsBrack]

@carhartl #540