Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document correct ES6 module usage to avoid "SyntaxError: import not found: default" #423

Closed
FagnerMartinsBrack opened this issue Mar 31, 2018 · 9 comments

Comments

@FagnerMartinsBrack
Copy link
Member

Probably test in a browser that supports ES6 without using any library and document accordingly.

@kitak
Copy link

kitak commented Apr 18, 2018

@FagnerMartinsBrack

I tried the contents of #426 , but it seems that it will not be solved by import * as Cookies from './js-cookie-master/src/js.cookie.js';.
The Cookies variable is Module object.

2018-04-18 16 20 01

If object's name is not Cookies, I can refer to window.Cookies and it will work.
I think that this project needs another file that is ESModule target. I'll create p-r.

@FagnerMartinsBrack
Copy link
Member Author

FagnerMartinsBrack commented Apr 24, 2018

It seems documenting ES6 is more trouble than it's worth.

I reverted the commit.

Let's use this issue to test on browsers without extra dependencies and document accordingly, without assuming that the developer is using another third-party tool.

Revert commit: d8b016b

@rapeflower
Copy link

TypeError: p.a.setCookie is not a function(…)

@DoubleCouponDay

This comment has been minimized.

@FagnerMartinsBrack

This comment has been minimized.

@DoubleCouponDay

This comment has been minimized.

@xyzdata

This comment has been minimized.

@xgqfrms

This comment has been minimized.

@carhartl carhartl modified the milestones: v2.2.1, v3.0.0 Sep 5, 2019
@carhartl
Copy link
Member

carhartl commented Sep 9, 2019

Closed via #537

@carhartl carhartl closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants