Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the CLI runner setup used in runtest262.mjs #219

Open
12wrigja opened this issue Feb 6, 2023 · 0 comments
Open

Add tests for the CLI runner setup used in runtest262.mjs #219

12wrigja opened this issue Feb 6, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@12wrigja
Copy link
Contributor

12wrigja commented Feb 6, 2023

As @justingrant pointed out on #218 our runtest262.mjs script doesn't really have test coverage, and as the underlying test runner ends up with more features it would be good to verify that the command wiring there works.

One potential solution could be to have another CI run that:

  • runs test262 and verifies the output contains markers indicating that the runner actually ran some (all?) tests.
  • runs test262 with a set glob and verifies that only those tests ran
  • maybe runs the --help integration and verifies something from there?
@12wrigja 12wrigja added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@12wrigja