Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opaque hexadecimal color values should be resolved to rgb #135

Open
cdoublev opened this issue May 4, 2021 · 0 comments
Open

Opaque hexadecimal color values should be resolved to rgb #135

cdoublev opened this issue May 4, 2021 · 0 comments

Comments

@cdoublev
Copy link

cdoublev commented May 4, 2021 •
edited

This test expectation is wrong:

style.color = '#ffffffff';
expect(style.color).toEqual('rgba(255, 255, 255, 1)');

In Chrome/Firefox:

target.style.color = '#ffffffff'
console.log(target.style.color) // "rgb(255, 255, 255)"

Though I believe that this is not described in any specification.
@cdoublev cdoublev changed the title Hexadecimal color values with alpha === 1 should be resolved to rgb Opaque hexadecimal color values should be resolved to rgb May 4, 2021
@cdoublev cdoublev mentioned this issue May 10, 2021
Closed
cdoublev added a commit to cdoublev/cssstyle that referenced this issue May 24, 2021
@cdoublev
fix: parsing color
77347d4 
Fixes jsdom#134, jsdom#135, jsdom#136
cdoublev added a commit to cdoublev/cssstyle that referenced this issue Jun 9, 2021
@cdoublev
fix: parsing color
6284eaa 
Fixes jsdom#134, jsdom#135, jsdom#136
cdoublev added a commit to cdoublev/cssstyle that referenced this issue Jun 10, 2021
@cdoublev
fix: parsing color
e90b358 
Fixes jsdom#134,
jsdom#135,
jsdom#136
cdoublev added a commit to cdoublev/cssstyle that referenced this issue Jun 11, 2021
@cdoublev
fix: parsing color
69c7df4 
Fixes jsdom#134,
jsdom#135,
jsdom#136
cdoublev added a commit to cdoublev/cssstyle that referenced this issue Jun 14, 2021
@cdoublev
fix: parsing color
258bc65 
Fixes jsdom#134,
jsdom#135,
jsdom#136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cdoublev