Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDOM fails in real-world environments like reddit, and youtube/rumble watch page #3685

Open
JijaProGamer opened this issue Feb 23, 2024 · 0 comments

Comments

@JijaProGamer
Copy link

Node version: v20.11.0
JsDOM version: 24.0.0

Minimal reproduction case:

import gaxios from "gaxios"
import { JSDOM, ResourceLoader } from "jsdom"

const userAgent = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.3"
const url = "https://rumble.com/v343twz-best-wireless-router-in-2023-asus-rt-axe7800-review.html"

async function run(){
    const response = await gaxios.request({
        url: url,
        method: "GET",
        headers: {
            ["User-Agent"]: userAgent
        }
    });

    const dom = new JSDOM(response.data, {
        url: url,
        referrer: "https://google.com/",
        contentType: "text/html",
        includeNodeLocations: false,
        storageQuota: 10000000,
        runScripts: "dangerously",
        resources: new ResourceLoader({
            strictSSL: true,
            userAgent: userAgent,
        }),
        pretendToBeVisual: true,
        userAgent: userAgent
    });
}

run()

Looking at the exact same URL on a browser, there are no errors, however, looking at the console output after running new JSDOM, you can see this:

Error: Uncaught [ReferenceError: Rumble is not defined]
    at reportException (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\helpers\runtime-script-errors.js:66:24)   
    at processJavaScript (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:240:7)  
    at HTMLScriptElementImpl._innerEval (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:173:5)
    at C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:114:12
    at ResourceQueue.push (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\browser\resources\resource-queue.js:53:16)    
    at HTMLScriptElementImpl._fetchInternalScript (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:113:21)
    at HTMLScriptElementImpl._eval (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:167:12)
    at HTMLScriptElementImpl._poppedOffStackOfOpenElements (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:130:10)
    at JSDOMParse5Adapter.onItemPop (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\browser\parser\html.js:175:43)      
    at Parser.onItemPop (C:\Users\Bloxxy\Documents\rumble-core\node_modules\parse5\dist\cjs\parser\index.js:158:90) ReferenceError: Rumble is not defined
    at https://rumble.com/v343twz-best-wireless-router-in-2023-asus-rt-axe7800-review.html:11:1
    at Script.runInContext (node:vm:133:12)
    at Object.runInContext (node:vm:287:6)
    at processJavaScript (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:238:10) 
    at HTMLScriptElementImpl._innerEval (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:173:5)
    at C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:114:12
    at ResourceQueue.push (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\browser\resources\resource-queue.js:53:16)    
    at HTMLScriptElementImpl._fetchInternalScript (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:113:21)
    at HTMLScriptElementImpl._eval (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:167:12)
    at HTMLScriptElementImpl._poppedOffStackOfOpenElements (C:\Users\Bloxxy\Documents\rumble-core\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:130:10)

This error might imply that scripts don't run in the same order as the browser, or something is missing, maybe iFrame support or something alike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant