[[FIX]] Allow destructuring in setter parameter

jshint · Feb 14, 2016 · 97d0ac1 · 97d0ac1
1 parent ea0aeac
commit 97d0ac1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/jshint.js b/src/jshint.js
@@ -3259,7 +3259,7 @@ var JSHINT = (function() {
           // Don't warn about getter/setter pairs if this is an ES6 concise method
           if (nextVal === "get" && i && p) {
             warning("W076", t, p[0], i);
-          } else if (nextVal === "set" && i && (!p || p.length !== 1)) {
+          } else if (nextVal === "set" && i && f["(metrics)"].arity !== 1) {
             warning("W077", t, i);
           }
         } else {

diff --git a/tests/unit/core.js b/tests/unit/core.js
@@ -2071,5 +2071,17 @@ exports["gh-2838"] = function (test) {
     .addError(5, "'d' was used before it was declared, which is illegal for 'let' variables.")
     .test(code, { esversion: 6 });
 
+  test.done();
+};
+
+exports["destructuring in setter parameter"] = function (test) {
+
+  TestRun(test).test([
+    "var a = {",
+    "  get x() {},",
+    "  set x({ a, b }) {}",
+    "};"
+  ], { esversion: 6 });
+
   test.done();
 };