[[FIX]] Avoid crashing on invalid input #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent extension to the `instanceof` operator introduced logic that performed property access on the result of parsing the operator's right-hand expression operand. Because invalid code may not specify such an expression, this logic led to program crashes in response to the invalid syntax. Ensure that when the `instanceof` operator appears without a right-hand expression operand, JSHint reports a syntax error and exits gracefully.
rwaldron
reviewed
Oct 17, 2016
| // `expression` function. | ||
| if (!right) { | ||
| return token; | ||
| } |
|
Thanks, Rick! |
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Oct 18, 2016
A recent extension to the `instanceof` operator introduced logic that performed property access on the result of parsing the operator's right-hand expression operand. Because invalid code may not specify such an expression, this logic led to program crashes in response to the invalid syntax. Ensure that when the `instanceof` operator appears without a right-hand expression operand, JSHint reports a syntax error and exits gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent extension to the
instanceofoperator introduced logic thatperformed property access on the result of parsing the operator's
right-hand expression operand. Because invalid code may not specify such
an expression, this logic led to program crashes in response to the
invalid syntax.
Ensure that when the
instanceofoperator appears without a right-handexpression operand, JSHint reports a syntax error and exits gracefully.
This should resolve gh-3039. @rwaldron mind taking a look?