[[FIX]] Remove null value from errors array
#3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reporting unrecoverable errors, JSHint would insert two elements into the global `errors` array: a descriptor for the error itself, and a `null` value. Because this behavior is undocumented and inconsistent, it is most likely the result of a programming error. Ensure that the `JSHINT.errors` collection contains only error descriptor.
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Oct 18, 2016
When reporting unrecoverable errors, JSHint would insert two elements into the global `errors` array: a descriptor for the error itself, and a `null` value. Because this behavior is undocumented and inconsistent, it is most likely the result of a programming error. Ensure that the `JSHINT.errors` collection contains only error descriptor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reporting unrecoverable errors, JSHint would insert two elements
into the global
errorsarray: a descriptor for the error itself, and anullvalue. Because this behavior is undocumented and inconsistent, itis most likely the result of a programming error. Ensure that the
JSHINT.errorscollection contains only error descriptor.@rwaldron This has been around since the first commit!
jshint/fulljslint.js
Line 5509 in ca120a7
Funny how the testing infrastructure was built up to tolerate it.