Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[Fix]] Update Lodash to latest 4.17.19 #3494

Merged
merged 1 commit into from Jul 25, 2020

Conversation

Alkarex
Copy link
Contributor

@Alkarex Alkarex commented Jul 20, 2020

Address vulnerability of type "Prototype Pollution in lodash" GHSA-p6mc-m468-83gw

It is not sure whether this is at all relevant for jshint, but at the moment, GitHub's Dependabot sends vulnerability alerts to all respositories with a dependency to jshint, e.g.
https://github.com/alexandrainst/node-red-contrib-parser-ini/network/alert/package-lock.json/lodash/closed

So it would be nice to issue a new jshint release ASAP to offer an easy way forward for those projects with a (dev) dependency to jshint.

https://github.com/lodash/lodash/wiki/Changelog

Address vulnerability of type "Prototype Pollution in lodash" GHSA-p6mc-m468-83gw

It is not sure whether this is at all relevant for jshint, but at the moment, GitHub's Dependabot sends vulnerability alerts to all respositories with a dependency to jshint, e.g.
https://github.com/alexandrainst/node-red-contrib-parser-ini/network/alert/package-lock.json/lodash/open

So it would be nice to issue a new jshint release ASAP to offer an easy way forward for those projects with a (dev) dependency to jshint.

https://github.com/lodash/lodash/wiki/Changelog
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling be689f6 on Alkarex:lodash_4.17.19 into 1013d51 on jshint:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling be689f6 on Alkarex:lodash_4.17.19 into 1013d51 on jshint:master.

@jugglinmike
Copy link
Member

Lodash's changelog seems reasonable, and our tests pass, so this is good to go. Thanks for the patch!

@jugglinmike jugglinmike merged commit 17d8f5a into jshint:master Jul 25, 2020
@Alkarex Alkarex deleted the lodash_4.17.19 branch July 27, 2020 09:40
jugglinmike pushed a commit to jugglinmike/jshint that referenced this pull request Aug 2, 2020
Address vulnerability of type "Prototype Pollution in lodash" GHSA-p6mc-m468-83gw

It is not sure whether this is at all relevant for jshint, but at the moment, GitHub's Dependabot sends vulnerability alerts to all respositories with a dependency to jshint, e.g.
https://github.com/alexandrainst/node-red-contrib-parser-ini/network/alert/package-lock.json/lodash/open

So it would be nice to issue a new jshint release ASAP to offer an easy way forward for those projects with a (dev) dependency to jshint.

https://github.com/lodash/lodash/wiki/Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants