Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #33

Open
tomsommer opened this issue Sep 13, 2018 · 1 comment
Open

Code cleanup #33

tomsommer opened this issue Sep 13, 2018 · 1 comment
Milestone

Comments

@tomsommer
Copy link

The project is suffering from a really bloated codebase. It should be cleaned up.

This includes having namespaces added (to not pollute the global scope with functions) and have correct access modifiers to internal methods and variables.

@jsmitty12
Copy link
Owner

I couldn't agree more and we're slowly moving towards this.

I started the process by adding some much needed tests around the TLD handlers (which is still in progress), but the end goal has always been to eliminate the PHP 4 era structure in favor a fully namespaced structure implementing today's best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants