Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval in generic_parser_b will fail on some domains (solution within) #51

Open
newalphamedia opened this issue Mar 2, 2020 · 1 comment

Comments

@newalphamedia
Copy link

newalphamedia commented Mar 2, 2020

The line:

eval($var . '="' . str_replace('"', '\"', $itm) . '";');

Should be:

$itm = rtrim($itm,"\\"); eval($var . '="' . str_replace('"', '\"', $itm) . '";');

Because if $itm has a \ at the end of the value, it will trigger a ParseError.

@kevinoo
Copy link

kevinoo commented Mar 21, 2023

Thanks for the tip!

I will import this fix in my version of packagist: kevinoo/phpwhois

Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants