Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpickr with Spectre: Icons broken #1502

Open
eduo opened this issue Mar 4, 2024 · 0 comments
Open

Flatpickr with Spectre: Icons broken #1502

eduo opened this issue Mar 4, 2024 · 0 comments

Comments

@eduo
Copy link

eduo commented Mar 4, 2024

Hi.

I've noticed that Flatpickr integration tries to use the current icon handling when using different libraries (for example, when using fontawesome or bootstrap it will change the labels accordingly) but for Spectre it seems to be broken.

Example (it's the standard Flatpickr example, but the library was changed to Spectre): https://is.gd/lLz069

As you can see, the icons are wrong:

image

The normal look would be this for fontawesome 3:

image

It should be noted that the icons seem to be broken also in JQuery UI and bootstrap 3, whereas in Bootstrap 2 they revert to text

It currently maps to icon-bookmark and icon-close to represent a calendar popup and a way to close the calendar, but for Spectre I'd recommend using icon-edit or icon-resize-vert to popup the calendar and icon-cross or for the second. Alternatively icon-plus and icon-minus could be used.

Since I'm loading via CDN, I can't override these. I was surprised they had never been reported either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants