Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no tests for unicode codepoints vs. utf8-encoded characters #592

Open
karenetheridge opened this issue Aug 28, 2022 · 0 comments
Open

no tests for unicode codepoints vs. utf8-encoded characters #592

karenetheridge opened this issue Aug 28, 2022 · 0 comments
Assignees
@karenetheridge
Labels
enhancement An enhancement to the tooling or structure of the suite (as opposed to a new test). missing test A request to add a test to the suite that is currently not covered elsewhere.

Comments

@karenetheridge
Copy link
Member

karenetheridge commented Aug 28, 2022 •
edited

no time to create a PR right now, so dropping this here to come back to, and for discussion in case for some reason this is controversial:

schema: { "maxLength": 3 }

passing test: "ಠ_ಠ"
failing test: "ಠ__ಠ"

In unicode, ಠ is 0x0CA0 (\x{0ca0}), and is utf8-encoded to 3 bytes: 0xE0 0xB2 0xA0 (\x{e0}\x{b2}\x{a0}).

(and also a similar test for minLength)
@karenetheridge karenetheridge self-assigned this Aug 28, 2022
@Julian Julian added missing test A request to add a test to the suite that is currently not covered elsewhere. enhancement An enhancement to the tooling or structure of the suite (as opposed to a new test). labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenetheridge karenetheridge

Labels
enhancement An enhancement to the tooling or structure of the suite (as opposed to a new test). missing test A request to add a test to the suite that is currently not covered elsewhere.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karenetheridge @Julian