Update CONTRIBUTING.md to remove outdated information #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This file is a brand new version of the contributing file to remove outdate information. Related issue: #1414
3 tasks
Relequestual
requested changes
Sep 8, 2023
There was a problem hiding this comment.
Made a few suggestions for change.
I think this would be easier to review by spreading the PR over multiple commits.
There are a lot of things that no longer apply, but we don't exactly have a replacememt process ready. Such as, we shouldn't mention drafts or milestones, because right now we aren't using them in any defined way.
This is a good start though for sure.
|
Pinging @benjagm (just a reminder). |
benjagm
commented
Sep 14, 2023
|
@benjagm it's your PR. I think @Relequestual's comments are for you to address. 😉 |
Thanks Greg! I totally forgot about this one 🤪 |
Co-authored-by: Ben Hutton <relequestual@gmail.com>
Co-authored-by: Ben Hutton <relequestual@gmail.com>
Co-authored-by: Ben Hutton <relequestual@gmail.com>
Adding suggestion made in the PR.
|
Thanks everyone for the reviews and comments. I tried to address all the changes with the last PR. |
Relequestual
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This file is a brand new version of the contributing file to remove outdate information.
Resolves #1414