New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prefixItems
keyword omitted behavior
#1481
base: main
Are you sure you want to change the base?
Conversation
@@ -1844,8 +1844,6 @@ this keyword applied a subschema. The value MAY be a boolean true if a subschema | |||
was applied to every index of the instance, such as is produced by the `items` | |||
keyword. This annotation affects the behavior of `items` and `unevaluatedItems`. | |||
|
|||
Omitting this keyword has the same assertion behavior as an empty array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to specify what the behavior of omitting the keyword is. (Either that or remove all other omission clauses; probably not.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compare to allOf
and friends, just removing it is consistent with how they are. Plenty of other keywords don't include a comparable sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this and for writing up the fix!
63465c6
to
99f57cd
Compare
Fixes #1480 to omit the sentence about omitting the keyword, as
allOf
etc do.Also fixes a small markdown error while I'm touching that section.