Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Documentation & Development Experience #41

Merged
merged 8 commits into from May 16, 2024

Conversation

Michael-Obele
Copy link
Collaborator

Pull Request Information

What kind of change does this PR introduce?

Documentation improvements and developer experience enhancements.

Issue Number:

*Closes #14: Project documentation on GitHub. This pull request introduces a CONTRIBUTING guide as requested in issue #14.

Screenshots/videos:

N/A (This pull request focuses on documentation and configuration changes.)

If relevant, did you update the documentation?

Yes, this pull request introduces a new CONTRIBUTING.md file and updates the README.md file.

Summary

This pull request improves the project's documentation and development experience in several ways:

  • Comprehensive CONTRIBUTING Guide: Provides clear instructions for contributing to the project, including reporting bugs, suggesting features, and making pull requests.
  • Enhanced README: Expands the README.md to offer a more thorough introduction to the project and simplifies local development setup.
  • Improved Developer Experience: Reduces unnecessary spell check warnings for Visual Studio Code users.

These changes aim to empower contributors, improve project understanding, and streamline development workflows.

Does this PR introduce a breaking change?

No, this pull request does not introduce any breaking changes.

@@ -0,0 +1,3 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Michael-Obele
any specific reason for this file change ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was supposed to be an internal setting for my VSCode; I will remove it.


* [**Reporting Bugs** 🐞](#reporting-bugs-🐞)
* [**Suggesting Features** 💡](#suggesting-features-💡)
* [**Improving the Website** 🌐](#improving-the-website-🌐)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here how's about adding one more section related to docs improvement.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will do just that. Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking amazing 🚀

CONTRIBUTING.md Show resolved Hide resolved
@DhairyaMajmudar
Copy link
Member

Hello @Michael-Obele left some changes, pls. once have a look on them : )

@Michael-Obele
Copy link
Collaborator Author

Hello @Michael-Obele left some changes, pls. once have a look on them : )

Hi @DhairyaMajmudar, Sure thing. I just made some changes; if you have time, please take a look and let me know if there is anything else I should change.

README.md Outdated Show resolved Hide resolved
Fix for data name change

Co-authored-by: Alok Gupta <alokgupta1560@gmail.com>
Copy link
Contributor

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Thanks!!

@benjagm benjagm merged commit 6ff8f38 into json-schema-org:main May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project documentation on GitHub
4 participants