Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.github][actions]: Migrate data validation to Landscape2 Validation Action #42

Closed
DarhkVoyd opened this issue May 6, 2024 · 1 comment · Fixed by #49
Closed

[.github][actions]: Migrate data validation to Landscape2 Validation Action #42

DarhkVoyd opened this issue May 6, 2024 · 1 comment · Fixed by #49
Assignees
Labels
✨ Enhancement New feature or request Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@DarhkVoyd
Copy link
Member

Description:
Currently, on every PR we run a custom workflow to validate data files including landscape.yml, settings.yml, guide.yml using build command provided by the landscape tool for our CI/CD workflow. I suggest that we use the official validator action for the PR and then we can maintain our custom deploy logic separately. This way, we won't have to maintain the tool's data validation manually incase there are any breaking changes given this warning on the repo.

Warning

Landscape2 is at an early stage of development. There may be breaking changes in the future to the command usage, flags, and configuration file formats.

Suggested Approach:

  • I suggest that we migrate to the official action at Landscape2 Validation Action, for our custom workflow.
  • We could split our current workflow into two separate workflows, one workflow to validate all files including settings, guide, data yaml and another workflow to deploy to cloudflare.
@DarhkVoyd DarhkVoyd added Status: Available No one has claimed responsibility for resolving this issue. ✨ Enhancement New feature or request labels May 6, 2024
@aialok aialok self-assigned this May 8, 2024
@aialok
Copy link
Collaborator

aialok commented May 8, 2024

I am working on this.
Thank you : )

@DarhkVoyd DarhkVoyd added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement New feature or request Status: In Progress This issue is being worked on, and has someone assigned.
2 participants