Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference pages broken on iOS safari (invalid Regular Expression) #255

Open
anttiviljami opened this issue Dec 2, 2023 · 13 comments
Open
Assignees
Labels
🐛 Bug Indicates that the issue is a bug or defect. help wanted Extra attention is needed Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@anttiviljami
Copy link

anttiviljami commented Dec 2, 2023

Describe the bug

How to Reproduce

Launch any reference page on iOS Safari, e.g. https://json-schema.org/understanding-json-schema/reference/string

Expected behavior

Should render the page on iOS safari

Details

Screenshot 2023-12-02 at 11 04 49
Screenshot 2023-12-02 at 11 05 40

@anttiviljami anttiviljami added the 🐛 Bug Indicates that the issue is a bug or defect. label Dec 2, 2023
@Relequestual Relequestual added the help wanted Extra attention is needed label Dec 2, 2023
@Relequestual
Copy link
Member

Hey @anttiviljami
Firstly thanks for reporting.
Secondly, can you let me know specifically what version of iOS you're using here please? =]

@anttiviljami
Copy link
Author

5A928B24-5BEA-4E6D-9799-5DB6168BDD4F

@benjagm
Copy link
Collaborator

benjagm commented Dec 3, 2023

i am not able to reproduce this in my macbook/safari.

@kayx23
Copy link

kayx23 commented Dec 8, 2023

I experience the same in my MacBook air Safari. None of the navbar items can be rendered:

image

In Chrome it works fine.

I'm on Catalina (...yes still).

@benjagm
Copy link
Collaborator

benjagm commented Dec 8, 2023

Thanks for filling @anttiviljami and @kayx23 ! Can you please check if the issue has been fixed here:
https://6ca79aae.website-2v2.pages.dev/understanding-json-schema/reference/string

@kayx23
Copy link

kayx23 commented Dec 8, 2023

@benjagm still happening for me

image

image

@Relequestual
Copy link
Member

It looks like lookbehind support was added in Safari 16.4. I assume this means iOS 16.4 onwards too.
Relevant PR: WebKit/WebKit#7109

If are are able to update, this would be ideal.
If anyone else is able to identify and fix the problem, we would welcome a further PR.

@benjagm benjagm added the Status: Available No one has claimed responsibility for resolving this issue. label Feb 26, 2024
@MonalSD
Copy link

MonalSD commented Feb 27, 2024

@benjagm It would be great if you can assign this issue to me. i’ll start on it

@benjagm
Copy link
Collaborator

benjagm commented Feb 27, 2024

This is a difficult one @MonalSD . All yours.

I tried myself in this draft PR but it didn't work: #257

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Feb 27, 2024
@MonalSD
Copy link

MonalSD commented Mar 10, 2024

@benjagm I tried but couldn't reach to the desired solution. Thankyou

@benjagm
Copy link
Collaborator

benjagm commented Mar 10, 2024

Thanks Monal! This is a really difficult bug. I also spent some days working on it too so .... thanks for trying!

@benjagm benjagm added Status: Available No one has claimed responsibility for resolving this issue. and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Mar 10, 2024
@vickywane
Copy link

Hello @benjagm,

Has there been any other release to fix this bug?
I'd love to give it s shot.

Starting with reproducing the error across my devices.

@benjagm
Copy link
Collaborator

benjagm commented Apr 18, 2024

Has there been any other release to fix this bug?

No. We could not fix it. Thanks a lot for your interest on this one.

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. help wanted Extra attention is needed Status: In Progress This issue is being worked on, and has someone assigned.
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

6 participants