Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specs do not pass against Rails edge #142

Closed
tagliala opened this issue Feb 26, 2023 · 1 comment · Fixed by #149
Closed

Specs do not pass against Rails edge #142

tagliala opened this issue Feb 26, 2023 · 1 comment · Fixed by #149

Comments

@tagliala
Copy link
Contributor

tagliala commented Feb 26, 2023 •
edited

Ref: https://github.com/jsonapi-rb/jsonapi-rails/actions/runs/4275332544/jobs/7442603511

Bisected to: rails/rails@e65d41a rails/rails#45957

This will be fixed after the release of rspec/rspec-rails#2631
@tagliala tagliala changed the title Does not work with Rails edge Specs do not pass against Rails edge Feb 26, 2023
@tagliala
Copy link
Contributor Author

I think now there is a legit issue with Rails edge. I will bisect and investigate

tagliala added a commit to tagliala/jsonapi-rails that referenced this issue May 23, 2023
@tagliala
Update rspec-rails dependency
e41f0cc 
Close jsonapi-rb#142
tagliala added a commit to tagliala/jsonapi-rails that referenced this issue May 23, 2023
@tagliala
Update rspec-rails dependency
a8ba799 
Bump the requirement to >= 4.0 (which supports Rails >= 4.2) to allow usage
of 6.x version in modern Rails

Close jsonapi-rb#142
@tagliala tagliala mentioned this issue May 23, 2023
Merged
@remear remear closed this as completed in 9243993 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update non-production code to fix specs against Rails edge tagliala/jsonapi-rails
1 participant
@tagliala