Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radio and checkboxes structure not correct #396

Open
AndreasReichl opened this issue Jan 6, 2022 · 5 comments
Open

radio and checkboxes structure not correct #396

AndreasReichl opened this issue Jan 6, 2022 · 5 comments

Comments

@AndreasReichl
Copy link

The Javascript templates for radio and checkboxes is not correct. It should be like:

<div class="radio"><input type="radio" id="unic_id"><label for="unic_id">Labelname</label></div>
<div class="checkbox"><input type="checkbox" id="unic_id"><label for="unic_id">Labelname</label></div>

Link to W3C: https://www.w3schools.com/tags/att_input_type_checkbox.asp

@tchapi
Copy link
Member

tchapi commented Jan 6, 2022

Hi @AndreasReichl

You are right, but then we break the Bootstrap3 element structure (which is <input> inside <label> as far as I understand (see here).

Which means: we should update to Bootstrap4 (https://getbootstrap.com/docs/4.6/components/forms/#checkboxes-and-radios)

What do you think ?

@Lord-EXE
Copy link

Lord-EXE commented Jan 6, 2022

Hi tchapi,

Bootrap 4 has been around since 2015 (see here), so you can let version 3 die. I've already rebuilt the whole thing and can send you a solution.

@tchapi
Copy link
Member

tchapi commented Jan 6, 2022

Yes I know, I haven't got much time to update the templates unfortunately :/

How about switching to Bootstrap 5 directly ? I will trigger a major version change anyway ... so that might be worth looking into, no ?

@AlphaNumeric99
Copy link

@tchapi Any plans for Bootstrap 5 in near future?

@AndreasReichl
Copy link
Author

AndreasReichl commented Feb 28, 2022 via email

@sdetweil sdetweil added restriction and removed Bug labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants