Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vague error message: #likely-a-validation-error #6

Open
tgrushka opened this issue Sep 28, 2023 · 1 comment
Open

Vague error message: #likely-a-validation-error #6

tgrushka opened this issue Sep 28, 2023 · 1 comment

Comments

@tgrushka
Copy link

My resume works with some themes:

But not others:

Most importantly, it does not work with mine, as I tweaked for accessibility and to meet my needs, and published:

There is no explanation. Can we please have an error message to the effect of:

  • The registry cannot find the theme package;
  • There was a parsing error in our resume, and exactly where it is;
  • The theme did not export the correct function signature or something similar;
  • The theme package generated an error, and what it is.
  • Print the raw error message.

These would be really helpful, as the schema has changed and a bunch of themes are now broken. Thanks!

@thomasdavis
Copy link
Member

thomasdavis commented Oct 18, 2023

Great and necessary feedback.

Will make sure this get's done this weekend.

(The only tricky part is that themes are community developed, and sometimes they crash for reasons out of the registries control, but the error can still be surfaced and more descriptive (and a link to the theme repo))

levino added a commit that referenced this issue Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants