Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with modern JS? #521

Open
mindplay-dk opened this issue Jan 5, 2020 · 0 comments
Open

Doesn't work with modern JS? #521

mindplay-dk opened this issue Jan 5, 2020 · 0 comments

Comments

@mindplay-dk
Copy link

This test fails with a cryptic error message:

https://jsperf.com/array-search-sets

ReferenceError: result is not defined.

Tests always seem to fail whenever I use modern keywords like const?

Or is this because setup/teardown and test-code isn't all defined/running in the same scope? (if so, how is teardown useful without being able to access any of the results generated by the tests?)

(I'd assume every test runs in a new iframe with setup, test-code and teardown "pasted" after each other, or how else does it work? how else would you get reliable results?)

It would be helpful if you could console.error after you catch, as currently there's no way to see which line generated the error.

Also, the preparation code rendering is broken, with two weird nested containers and some <script> tags showing up on the page - I have no idea if this is related.

scrolling-bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant