Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict typing mode #234

Open
Bubblyworld opened this issue Feb 28, 2023 · 1 comment
Open

Enable strict typing mode #234

Bubblyworld opened this issue Feb 28, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Bubblyworld
Copy link
Contributor

A few typescript-related improvements we could make:

  • enable "strict" mode and fix all resulting typing issues
  • collect and strongly type all of the basic generator bits, like InstallTarget and Install, etc

I've fixed a few bugs now that basically came down to types not being respected, so I think this would be good for the codebase, and it would make refactoring a lot easier.

@Bubblyworld Bubblyworld added the enhancement New feature or request label Feb 28, 2023
@Bubblyworld
Copy link
Contributor Author

Another one: currently typescript is not inferring optional types on interfaces since we don't have strict null checks enabled, which is causing it to think there's dead code in resolve.ts, for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant