Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #11

Open
MylesBorins opened this issue Aug 16, 2020 · 1 comment
Open

Testing #11

MylesBorins opened this issue Aug 16, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MylesBorins
Copy link
Member

We don't have any tests, we should have tests.
@MylesBorins MylesBorins added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 16, 2020
MylesBorins added a commit that referenced this issue Sep 3, 2020
@MylesBorins
test: initial tests for jstime::run_script
d749363 
Refs: #11
@MylesBorins
Copy link
Member Author

@devsnek @bengl I'm trying to think about how to test the jstime_core::import but at a tiny bit of a loss since there is no way to get the output as module evaluation returns undefined. Any thoughts / suggestions?

Perhaps we should be binding to a generic stream for output in core and only bind to stdout for cli?

MylesBorins added a commit that referenced this issue Sep 7, 2020
@MylesBorins
test: initial tests for jstime_core::run_script (#48)
48337dd 
Refs: #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MylesBorins