Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement WHATWG URL api #45

Open
MylesBorins opened this issue Sep 1, 2020 · 2 comments
Open

Implement WHATWG URL api #45

MylesBorins opened this issue Sep 1, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MylesBorins
Copy link
Member

Related to #44

While not entirely necessary based on the current jstime feature-set, having the URL api seems like a reasonable platform builtin, PTAL at https://github.com/jstime/jstime/tree/main/core/src/builtins for examples of our existing built ins console and queue microtask

https://url.spec.whatwg.org/
@MylesBorins MylesBorins added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 1, 2020
@bengl
Copy link
Contributor

bengl commented Sep 2, 2020

In osgood, we brought in https://www.npmjs.com/package/whatwg-url (along with related WHATWG things) via a webpacked bundle.

@MylesBorins
Copy link
Member Author

First pass at this in #54

MylesBorins added a commit that referenced this issue Sep 8, 2020
@MylesBorins
core: create URL builtin
7c9948c 
Closes: #45
MylesBorins added a commit that referenced this issue Sep 8, 2020
@MylesBorins
core: create URL builtin
2343a30 
Closes: #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bengl @MylesBorins