Make aria-role case sensitive

jsx-eslint · Oct 16, 2018 · 651366c · 651366c
1 parent 56d3b9a
commit 651366c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/__tests__/src/rules/aria-role-test.js b/__tests__/src/rules/aria-role-test.js
@@ -66,12 +66,14 @@ ruleTester.run('aria-role', rule, {
     { code: '<div role="foobar" />', errors: [errorMessage] },
     { code: '<div role="datepicker"></div>', errors: [errorMessage] },
     { code: '<div role="range"></div>', errors: [errorMessage] },
+    { code: '<div role="Button"></div>', errors: [errorMessage] },
     { code: '<div role=""></div>', errors: [errorMessage] },
     { code: '<div role="tabpanel row foobar"></div>', errors: [errorMessage] },
     { code: '<div role="tabpanel row range"></div>', errors: [errorMessage] },
     { code: '<div role="doc-endnotes range"></div>', errors: [errorMessage] },
     { code: '<div role />', errors: [errorMessage] },
     { code: '<div role={null}></div>', errors: [errorMessage] },
     { code: '<Foo role="datepicker" />', errors: [errorMessage] },
+    { code: '<Foo role="Button" />', errors: [errorMessage] },
   ].concat(invalidTests).map(parserOptionsMapper),
 });
diff --git a/src/rules/aria-role.js b/src/rules/aria-role.js
@@ -54,7 +54,7 @@ module.exports = {
       // value isn't in the form of a literal.
       if (value === undefined || value === null) { return; }
 
-      const normalizedValues = String(value).toLowerCase().split(' ');
+      const normalizedValues = String(value).split(' ');
       const validRoles = [...roles.keys()].filter(role => roles.get(role).abstract === false);
       const isValid = normalizedValues.every(val => validRoles.indexOf(val) > -1);